fix nkeys seed read \n caused invalid seed #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyqs
reviewed
Jun 1, 2023
| @@ -561,6 +563,7 @@ def sig_cb(nonce: str) -> bytes: | |||
| # into the pre allocated bytearray. | |||
| user_seed = bytearray(nkey_size) | |||
| f.readinto(user_seed) # type: ignore[attr-defined] | |||
| user_seed = user_seed.strip() | |||
There was a problem hiding this comment.
yes, all the seed related with nkeys will all need this strip, otherwise still cause invalid seed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if you read nkey files, the origin method will read \n , so it will cause nkey seed load error, invalid nkey seed.
just strip the \n will do the work
this request only add a seed.strip() likes line before nkey.from_seed to pure the seed