Added support to export subjects when fetching js.stream_info() #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyqs
reviewed
Dec 22, 2023
| @@ -68,12 +68,13 @@ async def find_stream_name_by_subject(self, subject: str) -> str: | |||
| raise NotFoundError | |||
| return info['streams'][0] | |||
|
|
|||
| async def stream_info(self, name: str) -> api.StreamInfo: | |||
| async def stream_info(self, name: str, subjects_filter: str = '>') -> api.StreamInfo: | |||
There was a problem hiding this comment.
I think we want subjects_filter to be an optional parameter by default so something like:
Suggested change
| async def stream_info(self, name: str, subjects_filter: str = '>') -> api.StreamInfo: | |
| async def stream_info(self, name: str, subjects_filter: str = None) -> api.StreamInfo: |
wallyqs
reviewed
Dec 22, 2023
| resp = await self._api_request( | ||
| f"{self._prefix}.STREAM.INFO.{name}", timeout=self._timeout | ||
| f"{self._prefix}.STREAM.INFO.{name}", req_data.encode(), timeout=self._timeout |
There was a problem hiding this comment.
would prefer to send the subjects_filter JSON only when explicitly specifying a subject.
|
Thanks for the PR, I left a couple of comments in case you want to address, I will include this fix in the next release. |
|
Commit included as part of this set of changes: #527 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for the python client to query subjects held in a stream.
The PR adds a field
subjectsto the js StreamState class (js/api.py)and populates it through the JetStreamManager.stream_info() method. It also adds a
subject_filterkeyword parameter to stream_info()