Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Request/Response implementation #59

Merged
merged 5 commits into from
Apr 4, 2018
Merged

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Apr 4, 2018

Port of the current implementation of request/response from the Go client, where a single subscription with a wildcard is responsible of handling the responses.
This style of request can be used via the request API, but without passing a callback parameter which now is changed to block and wait for a single response. This style of request/response is also faster than previous implementation:

# Before:

$ python3.6 benchmark/latency_perf.py 
Sending 10000 request/responses on [test]
#######################################
Test completed : 0.340 ms avg request/response latency

# After:

$ python3.6 benchmark/latency_perf.py 
Sending 10000 request/responses on [test]
#######################################
Test completed : 0.284 ms avg request/response latency

@wallyqs wallyqs merged commit c94c2fb into master Apr 4, 2018
@wallyqs wallyqs deleted the new-request-response branch April 4, 2018 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant