Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of eventmachine greater than 1.0.7 #103

Closed
sax opened this issue Apr 29, 2016 · 8 comments
Closed

Allow use of eventmachine greater than 1.0.7 #103

sax opened this issue Apr 29, 2016 · 8 comments
Assignees

Comments

@sax
Copy link

sax commented Apr 29, 2016

We have used git bisect to determine that this commit in eventmachine is what leads to test failures on OS X.

We currently have conflicting dependencies on eventmachine, and would like to update to a newer version, but are stuck because of nats' hard dependency of = 1.0.7.

@wallyqs
Copy link
Member

wallyqs commented Apr 29, 2016

Thanks for sharing, will take a look. This commit right? => eventmachine/eventmachine@cac5597

@sax
Copy link
Author

sax commented Apr 29, 2016

That's it.
On Thu, Apr 28, 2016 at 17:39 Waldemar Quevedo notifications@github.com
wrote:

Thanks for sharing, will take a look. This commit right? =>
eventmachine/eventmachine@cac5597
eventmachine/eventmachine@cac5597


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#103 (comment)

@sax
Copy link
Author

sax commented Apr 29, 2016

Sorry, I thought that was the commit link I was pasting!

@sax
Copy link
Author

sax commented Jun 30, 2016

Thank you!

I was curious if there was a (rough) plan on releasing a new version of the gem. If a new version was not going to be officially released in the near term, would it be possible to have this pre-released to rubygems?

My main point in asking is that we've seen segfaults in the current version of eventmachine, and were hoping to update that as soon as possible.

Thanks!

@wallyqs
Copy link
Member

wallyqs commented Jun 30, 2016

Currently aiming to make a (pre?)-release of the gem probably next week after doing a couple of TLS related pending updates. Segfaults you mention are with 1.0.7? Next release would be allowing use of 1.2.0.1 (currently latest).

@sax
Copy link
Author

sax commented Jun 30, 2016

segfaults are on 1.0.9.1, which someone did some voodoo to force through our Gemfile. It looks like a double free on releasing the event machine.

It might be a fault of our code, but we were hoping to rule out the old version of EM.

@wallyqs
Copy link
Member

wallyqs commented Jun 30, 2016

OK, thanks for the info

@wallyqs
Copy link
Member

wallyqs commented Jul 8, 2016

@sax ruby-nats client 0.7.0 is now on rubygems, let me know if it works for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants