Rework idle heartbeat for pull consumers #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarema
force-pushed
the
rework-heartbeats-for-pull
branch
from
c4d83ea
to
851654b
Compare
Jarema
force-pushed
the
rework-heartbeats-for-pull
branch
from
851654b
to
ff5a74f
Compare
| trace!("setting hearbeats"); | ||
| let timeout = self.batch_config.idle_heartbeat.saturating_mul(2); | ||
| self.heartbeat_timeout.get_or_insert_with(|| { | ||
| Box::pin(tokio::time::timeout(timeout, futures::future::pending())) |
There was a problem hiding this comment.
This could have been done with Sleep
There was a problem hiding this comment.
oh, right. I took it over from different approach I had before. Nice nit. Thx.
caspervonb
reviewed
Jul 21, 2023
Signed-off-by: Tomasz Pietrek <tomasz@nats.io> --amend Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Jarema
force-pushed
the
rework-heartbeats-for-pull
branch
from
ff5a74f
to
685337b
Compare
caspervonb
reviewed
Jul 21, 2023
| terminated: bool, | ||
| heartbeat_timeout: Option<Pin<Box<tokio::time::Sleep>>>, |
caspervonb
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tomasz Pietrek tomasz@nats.io