Add update metadata #1064
Merged
Add update metadata #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarema
force-pushed
the
add-update-metadata
branch
4 times, most recently
from
28126bb
to
529b467
Compare
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Jarema
force-pushed
the
add-update-metadata
branch
2 times, most recently
from
c33d831
to
748f3fd
Compare
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Jarema
force-pushed
the
add-update-metadata
branch
from
748f3fd
to
a0162fa
Compare
piotrpio
approved these changes
Jul 31, 2023
| ) -> Result<ObjectInfo, UpdateMetadataError> { | ||
| let mut info = self.info(object.as_ref()).await?; | ||
|
|
||
| // If name is being update, we need to check if other metadata with it already exists. |
There was a problem hiding this comment.
Suggested change
| // If name is being update, we need to check if other metadata with it already exists. | |
| // If name is being updated, we need to check if other metadata with it already exists. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tomasz Pietrek tomasz@nats.io