Give access to Subscription's crossbeam channel #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm OK with merging this once the doctest is fixed. Do you need a hand with fixing the compilation error in the doctest? |
|
Should be ok now. I haven't used doctests or clippy, so didn't know how to run them. |
|
LGTM, thank you! I'll cut a release that includes this in a few minutes |
|
0.9.10 has been published which includes this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives access to the a crossbeam Receiver in the Subscription struct. Useful for crossbeam_channel::select macro. Diff should speak for itself. I didn't find a way to select on multiple Subscriptions in one thread without access to the crossbeam channel. Is there a better way?
Offtopic: I used the async-nats with tokio at first, but I think async_nats::Subsciption::next implementation will lose messages if canceled by tokio::select.