Optimize jetstream::consumer::pull::Consumer::stream method.
#529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarema
force-pushed
the
jarema/pull-stream-rework
branch
from
d69ef8e
to
5e3eb1b
Compare
Jarema
commented
Jun 23, 2022
caspervonb
requested changes
Jun 23, 2022
Jarema
force-pushed
the
jarema/pull-stream-rework
branch
from
ece547f
to
0f9f588
Compare
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
caspervonb
reviewed
Jun 27, 2022
|
new approach 735 ms. Asserted payloads etc. |
caspervonb
reviewed
Jun 27, 2022
| ) | ||
| .await | ||
| } | ||
| pub async fn stream_with_config(&self, config: BatchConfig) -> Result<Stream<'_>, Error> { |
There was a problem hiding this comment.
Since we know we can easily run into issues with this, maybe we wanna hold off on the with_config variant til after this week's release?
Suggested change
| pub async fn stream_with_config(&self, config: BatchConfig) -> Result<Stream<'_>, Error> { | |
| pub async fn stream_with_config(&self, config: BatchConfig) -> Result<Stream<'_>, Error> { |
There was a problem hiding this comment.
@caspervonb I will follow up today with:
- make this private
- expose only batch, max bytes and heartbeats.
It's not released yet, so I would not bother with removing it, as it requires removing tests that will be needed the same day (pull with heartbeat).
caspervonb
approved these changes
Jun 27, 2022
This was referenced Jul 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.