Pull Consumer builder #541
Conversation
| self | ||
| } | ||
|
|
||
| pub fn expires(mut self, expires: Duration) -> Self { |
There was a problem hiding this comment.
We know there is a bug with expires in the server, but I still think we should expose that methods, as it's not client err. Also, not making it public forces us to remove (ignored) timeout test.
| consumer: &'a Consumer<Config>, | ||
| } | ||
|
|
||
| impl<'a> StreamBuilder<'a> { |
There was a problem hiding this comment.
Alternatively, since we store the configuration already in Stream.
We can consume it and have these methods act as if they're combinators?
(Devil's advocate, not sure if I prefer this or that yet)
There was a problem hiding this comment.
Was thinking about that, especially when started writing tests and using it, but I think it's better to not consumer.
Otherwise Stream builder would act differently than Batch, and we ... might want to allow calling stream again after error happening? Maybe, maybe no, but if we consume, its a no for sure.
There was a problem hiding this comment.
Yeah I'm unsure too, lets start with this and iterate over the next couple of releases.
Jarema
force-pushed
the
jarema/pull-builder
branch
from
90addeb
to
d47f2ee
Compare
No description provided.