Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change create_consumer to return Consumer #544

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Jul 3, 2022

Signed-off-by: Tomasz Pietrek tomasz@nats.io

@Jarema Jarema requested a review from caspervonb July 3, 2022 06:38
Copy link
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint doesn't pass, let's merge the other one and rebase to make sure.

Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
@caspervonb caspervonb force-pushed the jarema/create-consumer-returns-consumer branch from d997235 to 7df27ee Compare July 4, 2022 06:42
Copy link
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Jarema Jarema merged commit 37c40c0 into main Jul 4, 2022
@Jarema Jarema deleted the jarema/create-consumer-returns-consumer branch July 4, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants