Add pull builder for Fetch and Batch #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarema
force-pushed
the
jarema/new-pull-builder
branch
from
2d6ab85
to
9092f50
Compare
caspervonb
reviewed
Jul 12, 2022
| /// while let Some(Ok(message)) = messages.next().await { | ||
| /// println!("got message {:?}", message); | ||
| /// message.ack().await?; | ||
| /// } | ||
| /// Ok(()) | ||
| /// # } | ||
| /// ``` | ||
| pub async fn stream(&self) -> Result<Stream<'_>, Error> { | ||
| pub async fn messages(&self) -> Result<Stream<'_>, Error> { |
There was a problem hiding this comment.
Suggested change
| pub async fn messages(&self) -> Result<Stream<'_>, Error> { | |
| pub async fn messages(&self) -> Result<Messages<'_>, Error> { |
There was a problem hiding this comment.
yep, changed to that already.
| @@ -102,7 +102,7 @@ impl Consumer<Config> { | |||
| /// } | |||
| /// # Ok(()) | |||
| /// # } | |||
| pub fn stream_builder(&self) -> StreamBuilder<'_> { | |||
| pub fn stream(&self) -> StreamBuilder<'_> { | |||
There was a problem hiding this comment.
Suggested change
| pub fn stream(&self) -> StreamBuilder<'_> { | |
| pub fn stream(&self) -> Stream<'_> { |
Jarema
force-pushed
the
jarema/new-pull-builder
branch
from
45bf2a7
to
e4e2e12
Compare
Jarema
force-pushed
the
jarema/new-pull-builder
branch
from
e4e2e12
to
3106cd1
Compare
This was referenced Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.