Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout to request & request builder #616

Merged
merged 10 commits into from Sep 15, 2022
Merged

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Aug 25, 2022

No description provided.

@Jarema
Copy link
Member Author

Jarema commented Aug 25, 2022

msrv error is resolved #610 here.

Jarema and others added 6 commits August 26, 2022 17:47
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Co-authored-by: Casper Beyer <caspervonb@pm.me>
Co-authored-by: Casper Beyer <caspervonb@pm.me>
@Jarema Jarema force-pushed the jarema/add-timeouts-to-requests branch from cbec6e4 to 0e39748 Compare August 26, 2022 15:47
Copy link
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two naming nits, can bike shed later.

provisional lgtm

async-nats/src/client.rs Outdated Show resolved Hide resolved
async-nats/src/client.rs Outdated Show resolved Hide resolved
@Jarema Jarema merged commit 76f6c03 into main Sep 15, 2022
@Jarema Jarema deleted the jarema/add-timeouts-to-requests branch September 15, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants