Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull heartbeats #627

Merged
merged 3 commits into from
Sep 2, 2022
Merged

Pull heartbeats #627

merged 3 commits into from
Sep 2, 2022

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Sep 1, 2022

No description provided.

@Jarema Jarema marked this pull request as draft September 1, 2022 12:29
@Jarema Jarema marked this pull request as ready for review September 1, 2022 19:25
Copy link
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

"did not receive idle hearbeat in time",
)))))
}
Err(TryRecvError::Empty) => (),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note/comment why this is ignored.

Suggested change
Err(TryRecvError::Empty) => (),
Err(TryRecvError::Empty) => (),

@Jarema Jarema merged commit 8aefe13 into main Sep 2, 2022
@Jarema Jarema deleted the jarema/pull-hearbeats branch September 2, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants