Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix object store bucket names #697

Merged
merged 6 commits into from
Nov 8, 2022
Merged

Fix object store bucket names #697

merged 6 commits into from
Nov 8, 2022

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Nov 7, 2022

There was no interoperability between Go and Rust client because of this.

Copy link
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test case? 😁

@Jarema
Copy link
Member Author

Jarema commented Nov 7, 2022

Was thinking about it, but the only way to test interoperability is to introduce Go client with toolchain or at least nats cli binary.
I dont think its worth it.

@caspervonb caspervonb self-requested a review November 8, 2022 14:16
Copy link
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Jarema Jarema merged commit b6825ba into main Nov 8, 2022
@Jarema Jarema deleted the jarema/fix-object-store-name branch November 8, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants