Add extended purge #739
Merged
Add extended purge #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarema
force-pushed
the
jarema/extended-purge-api
branch
from
9ca3c58
to
2eb4885
Compare
|
addresses nats-io/nats-architecture-and-design#4 |
|
I've got a slightly different approach in mind, still using a builder but into_future to make it look like a single async call chain. Will raise a competing PR shortly. |
Jarema
force-pushed
the
jarema/extended-purge-api
branch
4 times, most recently
from
ac65c5a
to
006d40e
Compare
caspervonb
requested changes
Nov 23, 2022
async-nats/tests/jetstream_tests.rs
Outdated
| @@ -470,6 +470,34 @@ mod jetstream { | |||
|
|
|||
| assert_eq!(stream.info().await.unwrap().state.messages, 3); | |||
| } | |||
| #[tokio::test] | |||
| async fn send_purge() { | |||
There was a problem hiding this comment.
Suggested change
| async fn send_purge() { | |
| async fn purge() { |
async-nats/src/jetstream/stream.rs
Outdated
| SEQUENCE: ToAssign, | ||
| KEEP: ToAssign, | ||
| { | ||
| stream: crate::jetstream::stream::Stream, |
There was a problem hiding this comment.
You're in the same scope here?
Suggested change
| stream: crate::jetstream::stream::Stream, | |
| stream: Stream, |
Jarema
force-pushed
the
jarema/extended-purge-api
branch
from
a1f302f
to
ed7716e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.