fix(kv): Fixes key listing for async client to match go client #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomastaylor312
force-pushed
the
fix/keys_async
branch
from
5214730
to
616cb64
Compare
Jarema
requested changes
Jan 4, 2023
thomastaylor312
force-pushed
the
fix/keys_async
branch
from
616cb64
to
533d6db
Compare
|
Pretty sure the windows test failure is due to a flake, but I can't rerun the tests to check that |
The go client [filters out deleted and purged keys](https://github.com/nats-io/nats.go/blob/66009489432be03ff32e5384a2b502fe88f4c635/kv.go#L909) and the async client was not filtering out those keys. This fixes the behavior to be the same and is also slightly more efficient as we aren't iterating over the _entire_ stream of key value history to get the current keys Signed-off-by: Taylor Thomas <taylor@cosmonic.com>
thomastaylor312
force-pushed
the
fix/keys_async
branch
from
533d6db
to
e969343
Compare
|
@Jarema friendly reminder ping |
Jarema
reviewed
Jan 20, 2023
Jarema
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The go client filters out deleted and purged keys and the async client was not filtering out those keys. This fixes the behavior to be the same and is also slightly more efficient as we aren't iterating over the entire stream of key value history to get the current keys.
I also included an optional commit that I figured I'd do while I was here. The original documentation for this method suggested that the
keysmethod should be returning aStreamrather than an iter. So I implemented a stream version of it if desired. This commit can be popped off (or moved to a separate PR) depending on maintainer preference