Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vec to ToServerAddrs impl and improve docs examples #802

Merged
merged 3 commits into from
Jan 13, 2023

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Jan 13, 2023

No description provided.

@caspervonb
Copy link
Collaborator

Rename the PR for the changelog please 😄

@Jarema Jarema changed the title Jarema/improve to server addrs Add Vec to ToServerAddrs impl and improve docs examples Jan 13, 2023
Copy link
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Jarema Jarema force-pushed the jarema/improve-to-server-addrs branch from 73534ba to 3890253 Compare January 13, 2023 09:46
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
@Jarema Jarema force-pushed the jarema/improve-to-server-addrs branch from 3890253 to 3997ce3 Compare January 13, 2023 09:46
@Jarema Jarema merged commit 751f547 into main Jan 13, 2023
@Jarema Jarema deleted the jarema/improve-to-server-addrs branch January 13, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants