Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly delete consumer after iterating over kv keys #818

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Explicitly delete consumer after iterating over kv keys #818

merged 1 commit into from
Jan 26, 2023

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Jan 24, 2023

Signed-off-by: Tomasz Pietrek tomasz@nats.io

@Jarema
Explicitly delete consumer after iterating over kv keys
367597c 
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
@Jarema
Copy link
Member Author

Jarema commented Jan 24, 2023

closes #817

piotrpio
piotrpio approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

caspervonb
caspervonb approved these changes Jan 25, 2023
View reviewed changes
Copy link
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Jarema Jarema merged commit 250547c into main Jan 26, 2023
@Jarema Jarema deleted the jarema/delete-consumer-after-fethcing-keys branch January 26, 2023 09:06
@Jarema Jarema mentioned this pull request Jan 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caspervonb caspervonb caspervonb approved these changes

@piotrpio piotrpio piotrpio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Jarema @caspervonb @piotrpio