Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Stream a ref in Purge #877

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Make Stream a ref in Purge #877

merged 1 commit into from
Mar 20, 2023

Conversation

n1ghtmare
Copy link
Collaborator

Change Stream in stream.rs Purge to be a ref

@caspervonb caspervonb requested review from Jarema and caspervonb and removed request for Jarema March 14, 2023 01:57
caspervonb
caspervonb approved these changes Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@caspervonb caspervonb requested a review from Jarema March 14, 2023 03:49
Jarema
Jarema approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jarema Jarema merged commit e550b7d into nats-io:main Mar 20, 2023
@Jarema Jarema mentioned this pull request Mar 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caspervonb caspervonb caspervonb approved these changes

@Jarema Jarema Jarema approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@n1ghtmare @caspervonb @Jarema