Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canonicalize header::NATS_LAST_STREAM #948

Merged
merged 1 commit into from
May 1, 2023
Merged

Canonicalize header::NATS_LAST_STREAM #948

merged 1 commit into from
May 1, 2023

Conversation

caspervonb
Copy link
Collaborator

Closes #947

@caspervonb caspervonb requested a review from Jarema May 1, 2023 12:36
@caspervonb caspervonb changed the title Canonicalize NATS_LAST_STREAM Canonicalize header::NATS_LAST_STREAM May 1, 2023
Jarema
Jarema approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jarema Jarema merged commit debdc77 into nats-io:main May 1, 2023
@Jarema Jarema mentioned this pull request Jul 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarema Jarema Jarema approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The NATS_LAST_STREAM value should be canonicalized
2 participants
@caspervonb @Jarema