Fix build warning

nats-io · Jan 29, 2024 · c519d86 · c519d86
1 parent 9c2d16f
commit c519d86
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 9 deletions.
diff --git a/Sources/BenchmarkPubSub/main.swift b/Sources/BenchmarkPubSub/main.swift
@@ -26,7 +26,8 @@ try await withThrowingTaskGroup(of: Void.self) { group in
         for await msg in sub {
             let payload = msg.payload!
             if String(data: payload, encoding: .utf8) != "\(i)" {
-                print("invalid payload; expected: \(i); got: \(String(data: payload, encoding: .utf8))")
+                let emptyString = ""
+                print("invalid payload; expected: \(i); got: \(String(data: payload, encoding: .utf8) ?? emptyString)")
             }
             guard let headers = msg.headers else {
                 print("empty headers!")
@@ -38,6 +39,7 @@ try await withThrowingTaskGroup(of: Void.self) { group in
             if i%1000 == 0 {
                 print("received \(i) msgs")
             }
+            i += 1
         }
     }
 

diff --git a/Sources/BenchmarkSub/main.swift b/Sources/BenchmarkSub/main.swift
@@ -27,9 +27,10 @@ for i in 1...numMsgs {
         continue
     }
     if String(data: payload, encoding: .utf8) != "\(i)" {
-        print("invalid payload; expected: \(i); got: \(String(data: payload, encoding: .utf8))")
+        let emptyString = ""
+        print("invalid payload; expected: \(i); got: \(String(data: payload, encoding: .utf8) ?? emptyString)")
     }
-    guard let headers = msg?.headers else {
+    guard msg?.headers != nil else {
         print("empty headers!")
         continue
     }

diff --git a/Sources/NatsSwift/Extensions/Data+Parser.swift b/Sources/NatsSwift/Extensions/Data+Parser.swift
@@ -136,7 +136,7 @@ extension Data {
                     if let headersString = String(data: headersData, encoding: .utf8) {
                         let headersArray = headersString.split(separator: "\r\n")
                         // TODO: unused now, but probably we should validate?
-                        let versionLine = headersArray[0]
+                        // let versionLine = headersArray[0]
 
                         for header in headersArray.dropFirst() {
                             let headerParts = header.split(separator: ":")

diff --git a/Sources/NatsSwift/NatsConnection.swift b/Sources/NatsSwift/NatsConnection.swift
@@ -322,7 +322,7 @@ class ConnectionHandler: ChannelInboundHandler {
     }
 
     func writeMessage(_ message: ByteBuffer)  throws {
-        channel?.write(message)
+        _ = channel?.write(message)
         if channel?.isWritable ?? true {
             channel?.flush()
         }

diff --git a/Tests/NatsSwiftTests/Integration/ConnectionTests.swift b/Tests/NatsSwiftTests/Integration/ConnectionTests.swift
@@ -44,7 +44,7 @@ class CoreNatsTests: XCTestCase {
                 expectation.fulfill()
             }
         }
-        wait(for: [expectation], timeout: 5.0)
+        await fulfillment(of: [expectation], timeout: 5.0)
         await sub.complete()
     }
 
@@ -67,7 +67,7 @@ class CoreNatsTests: XCTestCase {
                 expectation.fulfill()
             }
         }
-        wait(for: [expectation], timeout: 5.0)
+        await fulfillment(of: [expectation], timeout: 5.0)
         await sub.complete()
      }
 
@@ -170,7 +170,7 @@ class CoreNatsTests: XCTestCase {
         try await client.connect()
         try client.publish("msg".data(using: .utf8)!, subject: "test")
         try await client.flush()
-        try await client.subscribe(to: "test")
+        _ = try await client.subscribe(to: "test")
         XCTAssertNotNil(client, "Client should not be nil")
 
 
@@ -207,7 +207,7 @@ class CoreNatsTests: XCTestCase {
         try await client.connect()
         try client.publish("msg".data(using: .utf8)!, subject: "test")
         try await client.flush()
-        try await client.subscribe(to: "test")
+        _ = try await client.subscribe(to: "test")
         XCTAssertNotNil(client, "Client should not be nil")