Add jwt auth #27
Merged
Add jwt auth #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
piotrpio
reviewed
Jan 25, 2024
| @@ -32,6 +37,11 @@ public struct Auth { | |||
| init(token: String) { | |||
| self.token = token | |||
| } | |||
| static func fromCredentials(_ credentials: URL) -> Auth { | |||
There was a problem hiding this comment.
Why not another init(credentials: URL). Same as for token and user/password
There was a problem hiding this comment.
I feel that will not work anyway... we will have also NKEYS, callback, etc. I wonder if we will have enough diversity in types to use init with bunch of overloads. But yeah - either we should move away from inits, or try to use it everywhere.
There was a problem hiding this comment.
@piotrpio let's leave it as it is, and we will figure out soon how to handle it when we have all auth methods.
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tomasz Pietrek tomasz@nats.io