Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readme and add oss requirements #30

Merged
merged 5 commits into from
Jan 29, 2024

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Jan 29, 2024

Signed-off-by: Tomasz Pietrek tomasz@nats.io

@Jarema Jarema requested a review from piotrpio January 29, 2024 08:33
@@ -8,10 +8,7 @@

**:warning: WARNING: THIS REPOSITORY IS UNDER REWORK AND SHOULD NOT BE USED AT THE MOMENT :warning: **
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**:warning: WARNING: THIS REPOSITORY IS UNDER REWORK AND SHOULD NOT BE USED AT THE MOMENT :warning: **
#### :warning: WARNING: THIS REPOSITORY IS UNDER REWORK AND SHOULD NOT BE USED AT THE MOMENT :warning:

** isn't rendering

CODE-OF-CONDUCT.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@Jarema Jarema requested a review from mtmk January 29, 2024 11:14
Jarema and others added 4 commits January 29, 2024 12:18
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Co-authored-by: Ziya Suzen <ziya@suzen.net>
Co-authored-by: Ziya Suzen <ziya@suzen.net>
@Jarema Jarema force-pushed the improve-readme-and-add-oss-requirements branch from db6fea5 to 55b244d Compare January 29, 2024 11:18
Copy link
Contributor

@mtmk mtmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just noticed a typo that's all

CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: Ziya Suzen <ziya@suzen.net>
@Jarema Jarema merged commit b3705c8 into main Jan 29, 2024
1 check passed
@Jarema Jarema deleted the improve-readme-and-add-oss-requirements branch January 29, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants