Add connection events #32
Conversation
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
piotrpio
force-pushed
the
add-connection-events
branch
from
d86dae3
to
65addc2
Compare
| @discardableResult | ||
| public func on(_ events: [NatsEventKind], _ handler: @escaping (NatsEvent) -> Void) -> String { | ||
| guard let connectionHandler = self.connectionHandler else { | ||
| return "" |
There was a problem hiding this comment.
Nothing really, the alternative would be to throw an error here and I thought it might be better to avoid it... Normally this method returns a callback ID so that it can be closed with off().
| @@ -362,7 +381,7 @@ class ConnectionHandler: ChannelInboundHandler { | |||
|
|
|||
| func write(operation: ClientOp) throws { | |||
| guard let allocator = self.channel?.allocator else { | |||
| throw NSError(domain: "nats_swift", code: 1, userInfo: ["message": "no allocator"]) | |||
| throw NatsClientError("no allocator") | |||
There was a problem hiding this comment.
maybe we should call those with a prefix like "internal error" to hint that this is not a user or server fault?
There was a problem hiding this comment.
I added prefixes on several errors
| case connected = "connected" | ||
| case disconnected = "disconnected" | ||
| case closed = "closed" | ||
| case error = "error" |
There was a problem hiding this comment.
should this variant also ontain the error?
There was a problem hiding this comment.
This is just an event kind so that it can be easily registered. I went with 2 types - NatsEvent and NatsEventKind because NatsEvent may contain additional data for an event (like in the case of .error), but the kind is just a simple string for registering.
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
| case connected = "connected" | ||
| case disconnected = "disconnected" | ||
| case closed = "closed" | ||
| case error = "error" |
No description provided.