Add tls support #33
Merged
Add tls support #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Jarema
requested changes
Feb 15, 2024
| @@ -70,6 +75,27 @@ public class ClientOptions { | |||
| return self | |||
| } | |||
|
|
|||
| public func enforceTls() -> ClientOptions { | |||
There was a problem hiding this comment.
This was a placeholder name. Let's rename to requireTls
| @@ -70,6 +75,27 @@ public class ClientOptions { | |||
| return self | |||
| } | |||
|
|
|||
| public func enforceTls() -> ClientOptions { | |||
| self.withTls = true | |||
There was a problem hiding this comment.
and maybe for consistency rename then that one too?
| tlsConfiguration.privateKey = .privateKey(privateKey) | ||
| } | ||
| let sslContext = try NIOSSLContext(configuration: tlsConfiguration) | ||
| // FIXME(jrm): Consider better way to pick hostname. |
There was a problem hiding this comment.
How do we pick the hostname in Go?
We discussed it a bit - but maybe we should pick the hostname of the URL we are currently trying to connect to?
There was a problem hiding this comment.
Agreed, but currently we always pick the first url anyway. I'll add url randomization in the next PR and use that one.
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
piotrpio
force-pushed
the
add-tls-support
branch
from
5fa7874
to
cf2703f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.