Add randomizing servers in connect #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrpio
force-pushed
the
url-randomize
branch
2 times, most recently
from
dfcc313
to
ebe4a8b
Compare
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
piotrpio
force-pushed
the
url-randomize
branch
from
ebe4a8b
to
c4ead3b
Compare
Jarema
requested changes
Feb 20, 2024
| @@ -13,9 +13,10 @@ public class ClientOptions { | |||
| private var pingInterval: TimeInterval = 60.0 | |||
| private var reconnectWait: TimeInterval = 2.0 | |||
| private var maxReconnects: Int = 60 | |||
There was a problem hiding this comment.
We should not set max reconnects by default, as it's a known footgun. It will be especially painful on mobile devices.
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.