Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request #41

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Add request #41

merged 2 commits into from
Mar 12, 2024

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Mar 11, 2024

Signed-off-by: Tomasz Pietrek tomasz@nats.io

Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
@piotrpio piotrpio self-requested a review March 12, 2024 07:42
Copy link
Contributor

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit.


let client = ClientOptions().url(URL(string: natsServer.clientURL)!).build()

Task {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should run swift-format on that

Sources/NatsSwift/NatsClient/NatsClient.swift Show resolved Hide resolved
Copy link
Contributor

@mtmk mtmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
@Jarema Jarema merged commit b555f87 into main Mar 12, 2024
1 check passed
@Jarema Jarema deleted the add-request branch March 12, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants