Make Acknowledgment spelling consistent
#657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Jarema
force-pushed
the
jarema/fix-typo
branch
from
ce90211
to
9a73d0c
Compare
ripienaar
reviewed
Dec 20, 2022
cli/consumer_command.go
Outdated
| @@ -658,9 +658,9 @@ func (c *consumerCmd) showInfo(config api.ConsumerConfig, state api.ConsumerInfo | |||
|
|
|||
| if config.AckPolicy != api.AckNone { | |||
| if state.AckFloor.Last == nil { | |||
| fmt.Printf(" Acknowledgment floor: Consumer sequence: %s Stream sequence: %s\n", humanize.Comma(int64(state.AckFloor.Consumer)), humanize.Comma(int64(state.AckFloor.Stream))) | |||
| fmt.Printf(" Acknowledgement floor: Consumer sequence: %s Stream sequence: %s\n", humanize.Comma(int64(state.AckFloor.Consumer)), humanize.Comma(int64(state.AckFloor.Stream))) | |||
There was a problem hiding this comment.
In american it's Acknowledgment and in british its Acknowledgement. Both are corect but we tend to use american english here
There was a problem hiding this comment.
Sure, but checking the codebase, everywhere else British version is used.
Should not call it "typo" though ;).
Those are only two uses of american ones for that word.
Examples:
if c.maxAckPending == -1 && cfg.AckPolicy != api.AckNone {
err = askOne(&survey.Input{
Message: "Maximum Acknowledgements Pending",
Default: "0",
Help: "The maximum number of messages without acknowledgement that can be outstanding, once this limit is reached message delivery will be suspended. Settable using --max-pending.",
}, &c.maxAckPending)
fisk.FatalIfError(err, "could not ask for maximum outstanding acknowledgements")
}
There was a problem hiding this comment.
Think we should make those American then :)
There was a problem hiding this comment.
Agree, will "reverse" this PR approach :)
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Jarema
changed the title
Acknowledgment spelling consistent.
Jarema
changed the title
Acknowledgment spelling consistent.Acknowledgment spelling consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a typo in the Consumer state.
Acknowledgment->Acknowledgement.