Parallel vanity #18
Closed
Parallel vanity #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
derekcollison
requested changes
Jul 22, 2019
| for i:=0; i < cpu; i++ { | ||
| go func() { | ||
| for i := 0; i < max; i++ { | ||
| if found != nil { |
There was a problem hiding this comment.
found needs to be protected, this will fail a race detector.
nk/main.go
Outdated
| wg.Add(cpu) | ||
| for i:=0; i < cpu; i++ { | ||
| go func() { | ||
| for i := 0; i < max; i++ { |
There was a problem hiding this comment.
Should max be divided up by cpu?
There was a problem hiding this comment.
if they are concurrent we are giving more chance to find it, but maybe that is not intuitive.
There was a problem hiding this comment.
Agree but I think max should still be honored.
nk/main.go
Outdated
| wg.Done() | ||
| return | ||
| } | ||
| spin := spinners[i%len(spinners)] |
There was a problem hiding this comment.
Only want one spinner no?
changed console spinner to be timer based
|
I fixed the comments - but just noticed that you have an open pr that does the same thing. You can pick the one you want. |
|
Take a look at it and let me know your thoughts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modified to use all available cores when fishing for a vanity key.