Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Travis with GitHub Actions #101

Merged
merged 5 commits into from
Sep 13, 2019
Merged

Replace Travis with GitHub Actions #101

merged 5 commits into from
Sep 13, 2019

Conversation

variadico
Copy link
Contributor

@variadico variadico commented Sep 11, 2019

Currently, we use Travis CI for this repo. This change will move us to GitHub
Actions.

These are some of the things we need to do so we have parity with Travis.

  • build
  • pass tests
  • upload coverage
  • release*

goveralls doesn't support github actions.
https://docs.coveralls.io/supported-ci-services

codecov does though! https://docs.codecov.io/docs/supported-ci-providers

This PR switches this repo from coveralls to codecov for coverage reports.

*I need this PR to merge so I can test the release workflow.

This currently tests with Go 1.13 and 1.12.9. In addition, it tests with Linux,
macOS, and Windows.

@coveralls
Copy link

coveralls commented Sep 11, 2019

Coverage Status

Coverage remained the same at 88.128% when pulling 2df7ac4 on github-actions into 21bd3c2 on master.

@variadico variadico force-pushed the github-actions branch 8 times, most recently from 7dcf75d to dbbe395 Compare September 11, 2019 23:09
@variadico variadico force-pushed the github-actions branch 2 times, most recently from 5d3bf02 to ff66506 Compare September 12, 2019 02:29
@codecov-io
Copy link

codecov-io commented Sep 12, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@e46a9d9). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #101   +/-   ##
=========================================
  Coverage          ?   86.24%           
=========================================
  Files             ?        6           
  Lines             ?      807           
  Branches          ?        0           
=========================================
  Hits              ?      696           
  Misses            ?       91           
  Partials          ?       20
Impacted Files Coverage Δ
collector/collector.go 76.15% <100%> (ø)
collector/streaming.go 86.36% <100%> (ø)
exporter/exporter.go 89.6% <100%> (ø)
collector/replicator.go 86.79% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e46a9d9...d5a1178. Read the comment docs.

@variadico variadico force-pushed the github-actions branch 3 times, most recently from 04f513b to 67e3a09 Compare September 12, 2019 23:30
@variadico variadico changed the title WIP: Add GitHub Actions Replace Travis with GitHub Actions Sep 12, 2019
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@variadico variadico merged commit e076217 into master Sep 13, 2019
@variadico variadico deleted the github-actions branch September 13, 2019 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants