Multistage Dockerfiles for linux and windows #44
Conversation
docker/linux/arm32v7/Dockerfile
Outdated
| RUN git clone https://github.com/nats-io/prometheus-nats-exporter.git . | ||
|
|
||
| # build | ||
| RUN CGO_ENABLED=0 GOARCH=arm GOARM=7 go build -v -a -tags netgo -installsuffix netgo -ldflags "-s -w" |
There was a problem hiding this comment.
I guess it is default, but should there be GOOS=linux here?
| FROM microsoft/nanoserver | ||
| COPY --from=0 /go/src/github.com/nats-io/prometheus-nats-exporter/prometheus-nats-exporter.exe /prometheus-nats-exporter.exe | ||
| EXPOSE 7777 | ||
| ENTRYPOINT ["/prometheus-nats-exporter.exe"] |
There was a problem hiding this comment.
I have been told that there should not be ENTRYPOINT here (same for windowsservercore dockerfile). Please check nats-io/nats-streaming-docker@9596dfa#diff-e2b7dae7d59ab0b01b6fa33dfcc4c7af for details.
There was a problem hiding this comment.
We need to update this in gnatsd too by the way. I did not get to do it yet.
There was a problem hiding this comment.
Thanks. I followed the chain of links and comments that finally lead here - because one can powershell into the images, we need to use CMD. I'll change this, but as we discussed offline, imo this isn't actually what we want in our images. If there were such a thing as a scratch that ran with windows, I'd use it here.
|
FYI, updated based on comments. |
Add multistage dockerfiles for:
After a release has been cut, the git clone APIs need to reference a release tag.