Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add -version flag #83

Merged
merged 2 commits into from
Jun 19, 2019
Merged

feat: add -version flag #83

merged 2 commits into from
Jun 19, 2019

Conversation

caarlos0
Copy link
Contributor

sometimes I don't know which version of the installer is running somewhere, this may help.

The version will be filled in by goreleaser when releasing...

thanks!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.247% when pulling 3a86c6b on caarlos0:version into ebb5a36 on nats-io:master.

wallyqs
wallyqs approved these changes Jun 19, 2019
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. We could modify the Dockerfile to use this to add the version dynamically too.

@wallyqs wallyqs merged commit 625409e into nats-io:master Jun 19, 2019
@caarlos0 caarlos0 deleted the version branch June 19, 2019 17:05
@wallyqs wallyqs mentioned this pull request Jun 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyqs wallyqs wallyqs approved these changes

@gzamboni gzamboni gzamboni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@caarlos0 @coveralls @wallyqs @gzamboni