Vendor dependencies #150
Vendor dependencies #150
Conversation
There was a problem hiding this comment.
Don't have to make the changes, but may want to use other approach for misspell to try be consistent.
I am wondering if this is going to cause issues in the server since server vendors go-nats-streaming and others. Some protobuf thing will then be vendored twice in the server?
.travis.yml
Outdated
| - EXCLUDE_VENDOR=$(go list ./... | grep -v "/vendor/") | ||
| - $(exit $(go fmt $EXCLUDE_VENDOR | wc -l)) | ||
| - go vet $EXCLUDE_VENDOR | ||
| - find . -type f -name '*' | grep -v vendor/ | xargs misspell -error |
There was a problem hiding this comment.
Or, to be inline with other repos and what we do about, you could do:
$(exit $(misspell -locale US . | grep -v "vendor/" | wc -l))
There was a problem hiding this comment.
I still find it hard to swallow to vendor gnatsd because it is used in tests. Tests are not vendor'ed but because you vendor go-nats and test.go imports gnatsd, we end-up importing it. What if test.go was removed and functions defined there were moved to some _test.go file? The danger is that as of now these are exported and since there were in test.go they are part of the library. We may break things by moving them. Care to experiment?
Resolves #149