Cleanup some code #296
Merged
Cleanup some code #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move all ping related fields into own pingInfo struct. - Use connection closed boolean to check/set closed state instead of setting nc to nil. That makes sc.nc immutable and not nil and so code using that doesn't have to capture/check. - Add a pubAckCloseChan that is closed during connection close to prevent publish call from being possibly blocked. Regarding last point, we have tests and I tried to add a new one but it would not catch the issue unless I would add a sleep in publishAsync() after check of connection close and before sending to pubAckChan. The race is that if the connection is fully closed between these two lines then if there are enough go routines trying to send to the pubAckChan or MaxPubAcksInflight is low, the channel could be full which would block the publishAsync() call. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
kozlovic
force-pushed
the
ping_and_conn_close_cleanup
branch
from
142729f
to
a4176bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
of setting nc to nil. That makes sc.nc immutable and not nil
and so code using that doesn't have to capture/check.
to prevent publish call from being possibly blocked.
Regarding last point, we have tests and I tried to add a new one
but it would not catch the issue unless I would add a sleep in
publishAsync() after check of connection close and before sending
to pubAckChan.
The race is that if the connection is fully closed between these
two lines then if there are enough go routines trying to send to
the pubAckChan or MaxPubAcksInflight is low, the channel could be
full which would block the publishAsync() call.
Signed-off-by: Ivan Kozlovic ivan@synadia.com