[CHANGED] Default Ping settings #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current defaults were too small and would cause a client to mark the connection as lost after 15 seconds or so. This means that a server restart or leadership change may lead to the client dropping the connection. Made the change so that the overall time the client keeps the connection valid is as long as the server default ping settings. Of course, user that use Pings() option are not affected. This is only changing the default values. Also, in the event that the server no longer has the client, the client will detect that at the first ping interval, which is 5 seconds (the interval has not changed). Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current defaults were too small and would cause a client to
mark the connection as lost after 15 seconds or so. This means
that a server restart or leadership change may lead to the client
dropping the connection.
Made the change so that the overall time the client keeps the
connection valid is as long as the server default ping settings.
Of course, user that use Pings() option are not affected. This
is only changing the default values.
Also, in the event that the server no longer has the client, the
client will detect that at the first ping interval, which is
5 seconds (the interval has not changed).
Signed-off-by: Ivan Kozlovic ivan@synadia.com