Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix go report card issues #80

Merged
merged 1 commit into from
Jun 23, 2016
Merged

Fix go report card issues #80

merged 1 commit into from
Jun 23, 2016

Conversation

mcqueary
Copy link

@coveralls
Copy link

coveralls commented Jun 23, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 86.147% when pulling 1a8745c on fix_go_report_card_issues into 25d50c5 on master.

@kozlovic
Copy link
Member

LGTM

@mcqueary
Copy link
Author

FYI I didn't bother fixing the tests that gocyclo thinks are too complex. That's a battle for another day perhaps.

@ColinSullivan1
Copy link
Member

LGTM.

@kozlovic kozlovic merged commit aa92e13 into master Jun 23, 2016
@kozlovic kozlovic deleted the fix_go_report_card_issues branch June 23, 2016 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mcqueary @coveralls @kozlovic @ColinSullivan1