[ADDED] Option setter for the URL client connects to #95

kozlovic · 2016-07-17T15:57:41Z

Also fixed the pub and sub example to use this option setter. They
would otherwise only be able to connect to localhost:4222.

Resolves #94

Also fixed the pub and sub example to use this option setter. They would otherwise only be able to connect to localhost:4222. Resolves #94

coveralls · 2016-07-17T16:00:32Z

Coverage increased (+0.1%) to 86.526% when pulling 3f726b0 on add_nats_url_option_setter into 1af8219 on master.

kozlovic · 2016-07-17T16:06:28Z

@ColinSullivan1 @aricart Please review at your earliest convenience on Monday.
@mcqueary We may want to issue a new release after this PR is merged. There has been few other option setters added and fixes since v.0.1.0.

kozlovic · 2016-07-17T16:36:59Z

@EduardFazliev No because we use . for the import, so we don't need to specify stan. Not sure why this example has been written this way as opposed to the pub one. Will update as part of a different PR.

ColinSullivan1 · 2016-07-19T16:07:43Z

examples/stan-pub.go

 	var clusterID string
 	var clientID string
 	var async bool
+	URL := stan.DefaultNatsURL


is this necessary with the flags below?

Good point, will use var instead.

ColinSullivan1 · 2016-07-19T16:08:56Z

LGTM.

ColinSullivan1 · 2016-07-19T16:09:23Z

examples/stan-sub.go

@@ -57,10 +55,12 @@ func main() {
 	var qgroup string
 	var unsubscribe bool

+	URL := DefaultNatsURL


Same as above... Nitpicky, I know. ;)

Will change it to var. Thanks!

aricart · 2016-07-19T16:26:56Z

LGTM!

coveralls · 2016-07-19T16:36:01Z

Coverage increased (+0.1%) to 86.526% when pulling d6edc7b on add_nats_url_option_setter into 1af8219 on master.

[ADDED] Option setter for the URL client connects to

3f726b0

Also fixed the pub and sub example to use this option setter. They would otherwise only be able to connect to localhost:4222. Resolves #94

kozlovic added the waffle:needs review label Jul 17, 2016

ColinSullivan1 reviewed Jul 19, 2016
View reviewed changes

Declare URL with var

d6edc7b

kozlovic merged commit beba61d into master Jul 19, 2016

kozlovic deleted the add_nats_url_option_setter branch July 19, 2016 16:36

kozlovic removed the waffle:needs review label Jul 19, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADDED] Option setter for the URL client connects to #95

[ADDED] Option setter for the URL client connects to #95

kozlovic commented Jul 17, 2016

coveralls commented Jul 17, 2016 •

edited

kozlovic commented Jul 17, 2016

kozlovic commented Jul 17, 2016

ColinSullivan1 Jul 19, 2016

kozlovic Jul 19, 2016

ColinSullivan1 commented Jul 19, 2016

ColinSullivan1 Jul 19, 2016

kozlovic Jul 19, 2016

aricart commented Jul 19, 2016

coveralls commented Jul 19, 2016 •

edited

[ADDED] Option setter for the URL client connects to #95

[ADDED] Option setter for the URL client connects to #95

Conversation

kozlovic commented Jul 17, 2016

coveralls commented Jul 17, 2016 • edited

kozlovic commented Jul 17, 2016

kozlovic commented Jul 17, 2016

ColinSullivan1 Jul 19, 2016

Choose a reason for hiding this comment

kozlovic Jul 19, 2016

Choose a reason for hiding this comment

ColinSullivan1 commented Jul 19, 2016

ColinSullivan1 Jul 19, 2016

Choose a reason for hiding this comment

kozlovic Jul 19, 2016

Choose a reason for hiding this comment

aricart commented Jul 19, 2016

coveralls commented Jul 19, 2016 • edited

coveralls commented Jul 17, 2016 •

edited

coveralls commented Jul 19, 2016 •

edited