inflight counting fixes #80
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ cache off nats connection to guard against it being nulled out by close + if it nats publish throws, remove the ack from the inflight map so it doesn't count against our limit forever
this unblocks any threads waiting within publish
+ previous behaviour was to block until inflight count was lower than max + can now control whether this blocking behaviour times out by setting Options.pubWait() + it still defaults to waiting forever + set pubWait to 0 to avoid blocking if max inflight is currently exceeded
|
The code has chance significantly apparently, how would you like to proceed on this change? |
|
Sorry, I haven’t yet looked at the new client lib release. When we move to the new library I will re-test for the original issue. If it still occurs then I’ll see whether I can update this patch. Thanks! |
|
FWIW, I’ve just looked over the sources on master and I don’t think the areas I patched have changed significantly. I can see that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fixes for issue #79