Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added checks, warnings, and exceptions for invalid extension_director… #45

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

natsunlee
Copy link
Owner

JobDefinition:

  • Exception will be raised if extension_directories entry is not a valid path.
  • Exception will be raised if extension_directories entry is not a directory.
  • Warning will be displayed if extension_directories entry is not a valid package (is a dir, but is missing __init__.py).
  • Warning will be displayed if importing a module found in any extension_directories, including default dirs, results in an exception. The offending module will be skipped and module discovery + import will continue.

@natsunlee natsunlee merged commit e562a20 into 0.6 Jan 28, 2024
@natsunlee natsunlee deleted the 42-extensions-directories-catch-exceptions branch January 28, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading extensions directories will stop early if importing a module raises exception
1 participant