Fix/dynamic ytdl package (#211)

* initial commit

* more changes

* tests and flake etc

* Remove commented youtube_dl import

* Change message from info to debug

README.rst

@@ -122,6 +122,7 @@ Other configuration options are::
     threads_max = 16            : number of parallel threads to run
     search_results = 15         : maximum number of search results to return
     playlist_max_videos = 20    : maximum number of videos in a playlist to return
+    youtube_dl_package = [name] : alternative package to replace "youtube-dl"
 
 
 Usage

mopidy_youtube/__init__.py

@@ -32,6 +32,7 @@ def get_config_schema(self):
         schema["strict_autoplay"] = config.Boolean(optional=True)
         schema["max_autoplay_length"] = config.Integer(optional=True)
         schema["max_degrees_of_separation"] = config.Integer()
+        schema["youtube_dl_package"] = config.String(optional=True)
         return schema
 
     def setup(self, registry):

mopidy_youtube/backend.py

@@ -69,6 +69,7 @@ def __init__(self, config, audio):
         youtube.musicapi_enabled = config["youtube"]["musicapi_enabled"]
         youtube.musicapi_cookie = config["youtube"].get("musicapi_cookie", None)
         youtube_music.own_channel_id = youtube.channel
+        youtube.youtube_dl_package = config["youtube"]["youtube_dl_package"]
         self.uri_schemes = ["youtube", "yt"]
         self.user_agent = "{}/{}".format(Extension.dist_name, Extension.version)
 

mopidy_youtube/ext.conf

@@ -12,3 +12,4 @@ autoplay_enabled = false
 strict_autoplay = false
 max_autoplay_length = 600
 max_degrees_of_separation = 3
+youtube_dl_package = youtube_dl

mopidy_youtube/youtube.py

@@ -1,11 +1,12 @@
+import importlib
 import json
 import os
 import re
 import shutil
 from concurrent.futures.thread import ThreadPoolExecutor
 
 import pykka
-import youtube_dl
+
 from cachetools import TTLCache, cached
 from mopidy.models import Image, ModelJSONEncoder
 
@@ -15,6 +16,8 @@
 api_enabled = False
 channel = None
 cache_location = None
+youtube_dl = None
+youtube_dl_package = "youtube_dl"
 
 
 def async_property(func):
@@ -292,6 +295,11 @@ def audio_url(self):
         youtube_dl.
         """
 
+        global youtube_dl
+        if youtube_dl is None:
+            logger.debug(f"using {youtube_dl_package} package for youtube_dl")
+            youtube_dl = importlib.import_module(youtube_dl_package)
+
         requiresUrl = self._add_futures([self], ["audio_url"])
         if requiresUrl:
             ytdl_options = {

tests/conftest.py

@@ -42,6 +42,7 @@ def config(tmp_path):
             "strict_autoplay": False,
             "max_autoplay_length": 600,
             "max_degrees_of_separation": 3,
+            "youtube_dl_package": "youtube_dl",
         },
         "proxy": {},
     }