Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make all li inside bq smaller font for backwards compatibility #1120

Conversation

ericscheid
Copy link
Collaborator

@ericscheid ericscheid commented Nov 27, 2020

Some brews were relying on the smaller font-size for column wrap
so make all <li> within <bq> smaller (including if inside <p>).

Some brews might now have extra space (vs some brews now overflowing the space they had before)
#1085 (comment)

…e all <li> within <bq> smaller (including if inside <p>).

Some brews might now have extra space (vs some brews now overflowing the space they had before)
naturalcrit#1085 (comment)
@calculuschild
Copy link
Member

calculuschild commented Nov 27, 2020

Is this behavior any different than just using the ul rule or whatever it was before? I'm leaning towards just fully reverting that change to fully avoid any unforseen side effects this new p rule adds. I'm sure somebody will come along and complain that now their image alignment has been ruined or something even if it gives them more space.

Does that sound reasonable? We can just put everything back where it was exactly and leave it stable, waiting for the new renderer version before making any changes to the styling.

@calculuschild
Copy link
Member

Alright, I have just reverted the original change back to ul in favor of this to avoid any other side effects. Let's keep the related issue open though and make it part of the #1096 Epic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants