Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Highlight token to marked #3188

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

dbolack-ab
Copy link
Collaborator

As I am already on a blasphemy streak, this is a PR to overload the tradition mapping for __thing__ to <mark>thing</mark>.

This overrides the __ as <strong> behavior in default marked.
@calculuschild calculuschild added blocked Waiting on a dependency, other feature, etc., first 🚀 V4 Wait for V4 labels Dec 14, 2023
@calculuschild calculuschild temporarily deployed to homebrewery-pr-3188 December 14, 2023 22:31 Inactive
@dbolack-ab
Copy link
Collaborator Author

A side note - if this is intended to only be used for a strikeout pattern then it is redundant vs the GHM ~ based pattern.It should be used differently or the markup indicators should be saved for another purpose.

@5e-Cleric 5e-Cleric added this to the Homebrewery v4 milestone Jan 16, 2024
@calculuschild calculuschild temporarily deployed to homebrewery-pr-3188 January 17, 2024 17:22 Inactive
@calculuschild calculuschild temporarily deployed to homebrewery-marked-high-fj8ev1 January 18, 2024 16:50 Inactive
@calculuschild calculuschild temporarily deployed to homebrewery-pr-3188 January 18, 2024 20:04 Inactive
@dbolack-ab dbolack-ab self-assigned this Jan 19, 2024
@Gazook89
Copy link
Collaborator

Gazook89 commented Feb 8, 2024

I'm kind of assuming there was discussion in Gitter about this back when you first opened it, but I couldn't find it with a quick search.

I hesitate with this because I'm not sure I see the utility in being able to <mark> text, beyond just having one more html tag we can then style. Personally, I just use the <del> tag that is easily available with ~~text~~ and then style it with css. I do think that mark is likely a more semantically appropriate tag for this, and in another environment I would fully support having more tags in the toolchest...

...but:

or the markup indicators should be saved for another purpose.

as you mention here, we have limited prime indicators available and thus we have to be very conservative. I don't think <mark> is unique/useful enough to use a good indicator on.

image

@dbolack-ab
Copy link
Collaborator Author

as you mention here, we have limited prime indicators available and thus we have to be very conservative. I don't think <mark> is unique/useful enough to use a good indicator on.

I tend to agree, however, I have failed, utterly, to think of a single better use for the markup that also suits the pattern.

@5e-Cleric
Copy link
Member

At the end of the day, we can use this for another feature if we think of it for v4, i say we give this a go.

@calculuschild
Copy link
Member

Taking more inspiration from Obsidian, they use ==Content== for highlighting. May be we could just follow that precedent again here and not have to worry about overriding underscores for now (plus, if we use _content_ for underline later, __content__ for highlighting might be similar enough to be confusing.)

@dbolack-ab
Copy link
Collaborator Author

Taking more inspiration from Obsidian, they use ==Content== for highlighting. May be we could just follow that precedent again here and not have to worry about overriding underscores for now (plus, if we use _content_ for underline later, __content__ for highlighting might be similar enough to be confusing.)

Good thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Waiting on a dependency, other feature, etc., first 🚀 V4 Wait for V4
Projects
Status: Not planned
Development

Successfully merging this pull request may close these issues.

None yet

5 participants