-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic Brew thumbnail generation option #3219
Closed
Closed
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
27d53f2
Remove old, non-base themes.
dbolacksn 699f64c
Revert "Remove old, non-base themes."
dbolacksn 1192307
Baseline functionality for thumbnail.
dbolacksn 180a8c8
Semi-working draft.
dbolacksn c6c0a46
Merge branch 'master' into MagicThumbnail
dbolacksn 33021e1
Merge branch 'master' into MagicThumbnail
dbolacksn 14a37c1
Merge branch 'master' into MagicThumbnail
dbolacksn cea05a3
Merge branch 'master' into MagicThumbnail
dbolack-ab 83ae4f9
Merge branch 'master' into MagicThumbnail
dbolacksn 81148b4
WIP
dbolacksn f0a8020
Merge branch 'master' of github.com:naturalcrit/homebrewery
dbolacksn 9848e4b
Merge branch 'master' of github.com:naturalcrit/homebrewery
dbolacksn 5d87508
Merge branch 'master' of github.com:naturalcrit/homebrewery
dbolacksn ec5f825
Merge branch 'master' of github.com:naturalcrit/homebrewery
dbolacksn b86502a
Merge branch 'master' of github.com:naturalcrit/homebrewery
dbolacksn 9d6076f
Merge branch 'master' of github.com:naturalcrit/homebrewery
dbolacksn 5494c02
Merge branch 'master' of github.com:naturalcrit/homebrewery
dbolacksn e458b9d
Merge branch 'master' into MagicThumbnail
dbolacksn File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious why this is an
OR
betweencontentDocument
andcontentWindow.document
? From what I can tell, it is the same thing?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My memory of the reference code is that it should be the same but for some browser situations, it may not be.