Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blocking notification to EditPage #3382

Merged
merged 48 commits into from
Jun 7, 2024
Merged

Add blocking notification to EditPage #3382

merged 48 commits into from
Jun 7, 2024

Commits on Mar 29, 2024

  1. Initial functionality pass

    @G-Ambatte
    G-Ambatte committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    963ec28 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2024

  1. Merge branch 'master' into addLockNotification-naturalcrit#3326

    @G-Ambatte
    G-Ambatte committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    fde1706 View commit details
    Browse the repository at this point in the history

  2. Nudge line and button spacing

    @G-Ambatte
    G-Ambatte committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    4bc07ce View commit details
    Browse the repository at this point in the history

  3. Update fixed text and add REMOVAL button (NYI)

    @G-Ambatte
    G-Ambatte committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    b4b4fbe View commit details
    Browse the repository at this point in the history

  4. Differentiate between Edit and Share messages

    @G-Ambatte
    G-Ambatte committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    4c6953a View commit details
    Browse the repository at this point in the history

  5. Fix test

    @G-Ambatte
    G-Ambatte committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    09cf5a9 View commit details
    Browse the repository at this point in the history

  6. I can spell, honest

    @G-Ambatte
    G-Ambatte committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    9f31a2c View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Merge branch 'master' into addLockNotification-naturalcrit#3326

    @G-Ambatte
    G-Ambatte committed May 9, 2024
    Configuration menu
    Copy the full SHA
    3a054f1 View commit details
    Browse the repository at this point in the history

  2. Update lock message

    @G-Ambatte
    G-Ambatte committed May 9, 2024
    Configuration menu
    Copy the full SHA
    10a7f34 View commit details
    Browse the repository at this point in the history

  3. Update error message

    @G-Ambatte
    G-Ambatte committed May 9, 2024
    Configuration menu
    Copy the full SHA
    f6daeb4 View commit details
    Browse the repository at this point in the history

  4. Pass ID to Lock Notification

    @G-Ambatte
    G-Ambatte committed May 9, 2024
    Configuration menu
    Copy the full SHA
    bf38f95 View commit details
    Browse the repository at this point in the history

  5. Add Share ID to lock notification

    @G-Ambatte
    G-Ambatte committed May 9, 2024
    Configuration menu
    Copy the full SHA
    632efe8 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2024

  1. Merge branch 'master' into addLockNotification-naturalcrit#3326

    @G-Ambatte
    G-Ambatte committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    2424d34 View commit details
    Browse the repository at this point in the history

  2. Shift NotificationPopup to shared components & update BrewRenderer ref

    @G-Ambatte
    G-Ambatte committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    a6ce366 View commit details
    Browse the repository at this point in the history

  3. Lint fix

    @G-Ambatte
    G-Ambatte committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    9307092 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Break Dialog out of NotificationPopup, restore NotificationPopup to o… 

    …riginal position
    @G-Ambatte
    G-Ambatte committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    8685c5c View commit details
    Browse the repository at this point in the history

  2. Fix for modals

    @G-Ambatte
    G-Ambatte committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    f3b01bc View commit details
    Browse the repository at this point in the history

  3. Tweak dismiss button styling

    @G-Ambatte
    G-Ambatte committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    1111d82 View commit details
    Browse the repository at this point in the history

  4. Add closeText prop

    @G-Ambatte
    G-Ambatte committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    e7735e2 View commit details
    Browse the repository at this point in the history

  5. Tweak NotificationPopup

    @G-Ambatte
    G-Ambatte committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    05ba7b4 View commit details
    Browse the repository at this point in the history

  6. Change all Modal references to Dialog

    @G-Ambatte
    G-Ambatte committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    865c567 View commit details
    Browse the repository at this point in the history

  7. Change dismiss button to use fa-dismiss

    @G-Ambatte
    G-Ambatte committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    5f6d5f5 View commit details
    Browse the repository at this point in the history

  8. Restore Info Circle to notification

    @G-Ambatte
    G-Ambatte committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    24e67e2 View commit details
    Browse the repository at this point in the history

  9. Small cleanup of Dialog component 

    Reduce number of `useEffects` needed
    @calculuschild
    calculuschild committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    491b38c View commit details
    Browse the repository at this point in the history

  10. linting

    @calculuschild
    calculuschild committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    99ff7fd View commit details
    Browse the repository at this point in the history

  11. Convert LockNotification.jsx to functional component

    @calculuschild
    calculuschild committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    7272544 View commit details
    Browse the repository at this point in the history

  12. Set local storage only if dismissKey prop exists

    @G-Ambatte
    G-Ambatte committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    ec514cd View commit details
    Browse the repository at this point in the history

  13. Merge branch 'master' into addLockNotification-naturalcrit#3326

    @calculuschild
    calculuschild committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    423413e View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Show dialog when dismissKey prop is not specified

    @G-Ambatte
    G-Ambatte committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    31b6e0c View commit details
    Browse the repository at this point in the history

  2. Shift LockNotification to use Dialog

    @G-Ambatte
    G-Ambatte committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    0efcd5d View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Tweak Dialog to work with showModal and show LockNotifications

    @G-Ambatte
    G-Ambatte committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    556ded9 View commit details
    Browse the repository at this point in the history

  2. Tweak LockNotification styling

    @G-Ambatte
    G-Ambatte committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    4f4cef0 View commit details
    Browse the repository at this point in the history

  3. Fix display property on dialog causing close() to not work

    @G-Ambatte
    G-Ambatte committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    9e041d2 View commit details
    Browse the repository at this point in the history

  4. Shift dismiss button, tweak local storage check

    @G-Ambatte
    G-Ambatte committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    fa7b3ea View commit details
    Browse the repository at this point in the history

  5. Change NotificationPopup to inline-block from block

    @G-Ambatte
    G-Ambatte committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    38fc647 View commit details
    Browse the repository at this point in the history

  6. Move dialog[open] to Dialog component styling

    @G-Ambatte
    G-Ambatte committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    ed39852 View commit details
    Browse the repository at this point in the history

  7. Move renderWarnings to use Dialog

    @G-Ambatte
    G-Ambatte committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    866548d View commit details
    Browse the repository at this point in the history

  8. Nudge popups left

    @G-Ambatte
    G-Ambatte committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    359a649 View commit details
    Browse the repository at this point in the history

  9. Revert dismiss styling to opacity change on hover

    @G-Ambatte
    G-Ambatte committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    8c31598 View commit details
    Browse the repository at this point in the history

  10. Refactor slightly

    @calculuschild
    calculuschild committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    7bb92bc View commit details
    Browse the repository at this point in the history

  11. Comment out dialog.less reference

    @G-Ambatte
    G-Ambatte committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    54ec1b8 View commit details
    Browse the repository at this point in the history

  12. Tweak notificationPopup.less 

    Stop the notification from covering the renderWarning when both are present
    @G-Ambatte
    G-Ambatte committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    476002a View commit details
    Browse the repository at this point in the history

  13. Dim background while Modal displayed

    @G-Ambatte
    G-Ambatte committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    8bbf2e1 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Remove unused useState

    @G-Ambatte
    G-Ambatte committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    33c2bee View commit details
    Browse the repository at this point in the history

  2. Cleanup comments. Fix Indentation.

    @calculuschild
    calculuschild committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    08b61a6 View commit details
    Browse the repository at this point in the history

  3. Lint notificationPopup.less

    @calculuschild
    calculuschild committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    fdf6acd View commit details
    Browse the repository at this point in the history

  4. Lint lockNotification.less

    @calculuschild
    calculuschild committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    6577078 View commit details
    Browse the repository at this point in the history

  5. Lint renderWarnings.less

    @calculuschild
    calculuschild committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    66fdf80 View commit details
    Browse the repository at this point in the history