Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc website updates #941

Merged
merged 13 commits into from
Apr 24, 2024
Merged

Misc website updates #941

merged 13 commits into from
Apr 24, 2024

Conversation

jasongao97
Copy link
Contributor

@jasongao97 jasongao97 commented Apr 22, 2024

Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for nature-of-code-2nd-edition ready!

Name Link
🔨 Latest commit e32bb47
🔍 Latest deploy log https://app.netlify.com/sites/nature-of-code-2nd-edition/deploys/662819cbe7dead000854988b
😎 Deploy Preview https://deploy-preview-941--nature-of-code-2nd-edition.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for nature-of-code-pdf ready!

Name Link
🔨 Latest commit e32bb47
🔍 Latest deploy log https://app.netlify.com/sites/nature-of-code-pdf/deploys/662819cba4ccf500080f200d
😎 Deploy Preview https://deploy-preview-941--nature-of-code-pdf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shiffman
Copy link
Member

shiffman commented Apr 22, 2024

This is looking great! For the chapter openings, I would suggest the following:

  • smaller font for the title/caption, also tighter fit right below the image
  • paragraph should also be smaller, maybe italicized?

Overall, I would like these openings to feel like they are something different, rather than the start of the written text of the chapter. The image can be emphasized but the caption and description should be minimized.

@tuantinghuang feel free to offer any thoughts!

@jasongao97
Copy link
Contributor Author

Chapter opening styles update!

image

@tuantinghuang
Copy link
Collaborator

This looks good! I was just comparing this to our Figma file, and some things that I notice -

  • chapter title: is it currently heavy or black? Maybe we can make it one font weight lighter? are we also using period instead of colon? eg. "Chapter 6: Physics Libraries" or "Chapter 6. Physics Libraries"
  • quote: font size can be as small as the image caption title, and smaller line spacing
  • image caption title: maybe also one font weight lighter?
  • image caption: I might also want to make the line spacing of the caption tiny bit smaller, but looks great as is right now too!

Attaching images to compare

Figma
Screenshot 2024-04-23 at 08 05 01

Website
Screenshot 2024-04-23 at 08 04 25

@jasongao97 I can also help editing the css code, let me know if you would prefer that! Thank you!

@jasongao97
Copy link
Contributor Author

chapter title: is it currently heavy or black? Maybe we can make it one font weight lighter? are we also using period instead of colon? eg. "Chapter 6: Physics Libraries" or "Chapter 6. Physics Libraries"

The font weight was 800, and I've adjusted it to 700. I also replaced the period with a colon.

quote: font size can be as small as the image caption title, and smaller line spacing

I've reduced the font size and adjusted the line spacing. Could you assist on the CSS part? I'm unsure if the current number is appropriate, and also the spacing between the quote and the author's name?

image caption title: maybe also one font weight lighter?

Done!

image caption: I might also want to make the line spacing of the caption tiny bit smaller, but looks great as is right now too!

I've slightly reduced the line spacing.

@shiffman
Copy link
Member

There are some small open items in the discussion above (for example, font size / spacing for quotes), but I think it makes sense to merge this so we can review the production site during our meeting and file new issues for additional work.

@shiffman shiffman merged commit 8634bd7 into main Apr 24, 2024
9 checks passed
@jasongao97 jasongao97 deleted the dev/misc-update branch July 12, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorporate Chapter Openings
3 participants