Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INSTALL does not copy hidden files #39

Closed
adur1990 opened this issue Nov 3, 2021 · 4 comments
Closed

INSTALL does not copy hidden files #39

adur1990 opened this issue Nov 3, 2021 · 4 comments

Comments

@adur1990
Copy link

adur1990 commented Nov 3, 2021

When using INSTALL, hidden files are not copied to the guest.
In my case, I try to build nexmon, which in turn requires the .git folder to built.
See the output below.

### RUN bash -c
    cp -r /btp/nexmon_patch /nexmon/patches/bcm43430a1/7_45_41_46/btp/
    cd /nexmon/patches/bcm43430a1/7_45_41_46/btp/ || exit 1
    source /nexmon/setup_env.sh
    make

fatal: Not a git repository: ../.git/modules/nexmon
@oxzi
Copy link
Member

oxzi commented Nov 9, 2021

Thanks for reporting this bug, @adur1990. Could you please supply your Pifile and at least a directory listing of the INSTALLed files resp. directories on your host?

The following is the current copy operation, depending on being a directory or a file.

if [[ -d "${src}" ]]; then
cp -r -T -P --preserve=mode "${src}" "${CHROOT_MOUNT}/${dst}"
else
cp -r -P --preserve=mode "${src}" "${CHROOT_MOUNT}/${dst}"
fi

In my understanding, a source directory should be copied to its destination with all its children. But, of course, I may be in the wrong here.

The used -P switch excludes symbolic links, as this might end up being messy. Might this be related to your issue?

@sensslen
Copy link
Contributor

sensslen commented Jan 6, 2022

Is there any reason why cp is used instead of the actual install command available?

@oxzi
Copy link
Member

oxzi commented Jan 17, 2022

Initially, the INSTALL command used the install program. This was changed in 8151607 for #5 and #8.

@jonashoechst
Copy link
Member

I tried to reproduce the error but was not able to. I've discussed with @adur1990 at it seems that the project structure he's using yielded the error.

Hidden files inside of folders are copied using the current implementation of pimod, which was already pointed out by @oxzi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants