Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PurpurMC Loud static / glitchy noise through bot #22

Closed
frizzbees opened this issue Jun 16, 2023 · 3 comments
Closed

PurpurMC Loud static / glitchy noise through bot #22

frizzbees opened this issue Jun 16, 2023 · 3 comments
Assignees
@naturecodevoid
Labels
bug Something isn't working

Comments

@frizzbees
Copy link

Describe the bug
Users speaking to eachother through the mod in game, and users speaking to the discord bot all produce clear audio. The issue is that any audio the bot forwards to the voice channel has very loud static and cuts out frequently

To Reproduce
Steps to reproduce the behavior:

  1. Setup server with latest version of this plugin, simple voice chat, and PurpurMC
  2. Run /dvc start
  3. Talk to person through the mod / discord bot
  4. Very loud static and glitchy audio coming from the bot itself
    Expected behavior
    A clear and concise description of what you expected to happen.
    Expected clear enough audio both ways
    Screenshots
    If applicable, add screenshots to help explain your problem.

Logs
First, set debug_level to 3 (or 2 if there's too much spam) in the Simple Voice Chat Discord Bridge configuration file. After restarting your server or using /dvc reloadconfig, please upload the server logs here (make sure they don't include any sensitive info).
(log since /dvc reloadconfig for log level 2)
https://mclo.gs/lRSx0ao

Versions (please complete the following information):

  • Minecraft: 1.20.1
  • Loader (paper, purpur, fabric, quilt, etc): purpur
  • Simple Voice Chat: latest
  • Simple Voice Chat Discord Bridge: latest

Additional context
Add any other context about the problem here.
@frizzbees frizzbees added the bug Something isn't working label Jun 16, 2023
@naturecodevoid
Copy link
Owner

This was reported to me via DMs also. Not sure why I never encountered it during testing, I'll have to look into it on the weekend or something

@naturecodevoid
Copy link
Owner

Could you provide logs with debug_level set to 3?

naturecodevoid added a commit that referenced this issue Jun 20, 2023
@naturecodevoid
fix(#22): fix audio issues with audio going to discord (see description)
85d597e 
- main fix: get rid of the stupid CompletableFuture stuff, this was causing issues because Bukkit's callSyncMethod is slow
- switch to a simpler volume adjustment method
- skip packets with a volume less than 0
- improve reset watcher by checking every 500ms if it's been 1 second, which should be an improvement
- improve reflection and NMS usage in paper to be safer
- add info about NMS on paper to CONTRIBUTING.md
@naturecodevoid
Copy link
Owner

Should be fixed with 2.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@naturecodevoid naturecodevoid

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@naturecodevoid @frizzbees