Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using DiscordSRV API to make VCs more secure and make a lobby for when no players are nearby #35

Open
TomSipsOnCurry opened this issue Dec 28, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@TomSipsOnCurry
Copy link

So, doing /dvc start is a bit clanky and insecure. For instance, you could do /dvc start and someone else could join the voice chat.

My proposed solution is to add an optional toggle to access discordSRV's linked accounts API. This way all you would have to do is join the VC, and then it'll know which mc player it is. No need for /dvc start or /dvc stop

@naturecodevoid
Copy link
Owner

naturecodevoid commented Dec 28, 2023

That could work, however, I am not sure how to do error handling. Suppose someone with the mod joins. How do we tell them that we can't make an audio sender? Users would have to give the bot permissions to disconnect players from the VC.

I think #23 is a better solution to this problem. I could also add functionality to disconnect users who join the VC but aren't linked to the person who did /dvc start.

@TomSipsOnCurry
Copy link
Author

Im am not sure which mod you are referring to. TO issue the limitation due to the audio sender, like you said disconnecting the player would be the better option.

@TomSipsOnCurry
Copy link
Author

I accidently closed the issue

@TomSipsOnCurry
Copy link
Author

I got an awesome idea, so basically there's a lobby, whenever no one is near a Player A (who uses discord), they get moved to the lobby. However when they get near another player with SVC, they get moved to the next available VC. If there is no available VCs they get notified about it in MC. This way people will only hog ontu the VCs when it is being used.

@naturecodevoid
Copy link
Owner

Im am not sure which mod you are referring to. TO issue the limitation due to the audio sender, like you said disconnecting the player would be the better option.

Audio senders are what we use to make a player talk using audio from discord. They do not work if the player has SVC installed on their client

I got an awesome idea, so basically there's a lobby, whenever no one is near a Player A (who uses discord), they get moved to the lobby. However when they get near another player with SVC, they get moved to the next available VC. If there is no available VCs they get notified about it in MC. This way people will only hog ontu the VCs when it is being used.

This could work, could you make another issue for it? Also FYI, it's unlikely that I will be implementing this anytime soon.

@naturecodevoid naturecodevoid added the enhancement New feature or request label Dec 29, 2023
@TomSipsOnCurry
Copy link
Author

Audio senders are what we use to make a player talk using audio from discord. They do not work if the player has SVC installed on their client

For the lobby, option they just wont get moved to the VC.

This could work, could you make another issue for it? Also FYI, it's unlikely that I will be implementing this anytime soon.

Ill just rename this issue, cause they go hand in hand. Its a solution to a solution.

@TomSipsOnCurry TomSipsOnCurry changed the title DiscordSRV Support DiscordSRV Support/Lobby Dec 29, 2023
@naturecodevoid naturecodevoid changed the title DiscordSRV Support/Lobby Allow using DiscordSRV API to make VCs more secure and make a lobby for when no players are nearby Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants