Skip to content

Commit

Permalink
stop using dplyr::bind_rows in flywire2fafb
Browse files Browse the repository at this point in the history
* again this *used* to work and not sure if dplyr has become fussier, it's an R 4 thing or
  a change on the spine server
* speed difference is negligible when dealing with matrices or even in rbinds favour
  (no tibble overhead)
  • Loading branch information
jefferis committed Aug 7, 2020
1 parent 93ecf44 commit 64f18c0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion R/flywire-coord.R
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ flywire2fafb <- function(xyz, method=c("mapmany", "map1"), chunksize=40e3,
chunkstoread=seq_len(nchunks)
b=by(xyzraw, chunks, as.matrix)
l=t(pbapply::pblapply(b, mapmany, ...))
mapres=dplyr::bind_rows(l)
mapres=do.call(rbind, l)
}
}
# let's get the xy deltas; dz is always 0
Expand Down

0 comments on commit 64f18c0

Please sign in to comment.