Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated parameter for toggling grid lines in plotly #432

Merged
merged 6 commits into from
Aug 18, 2020

Conversation

SridharJagannathan
Copy link
Collaborator

See #427

@SridharJagannathan
Copy link
Collaborator Author

@alexanderbates I have added a parameter gridlines which is by default set to FALSE and this will toggle the grid lines for you. I have already tested from my side, please check with various kinds of plots and let me know if it works.

@coveralls
Copy link

coveralls commented Apr 20, 2020

Coverage Status

Coverage increased (+0.09%) to 81.288% when pulling c98c69f on feature/plotly_grids_labels into 5c346d8 on master.

Copy link
Collaborator

@jefferis jefferis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted, it would be great if you could just document the gridlines argument once and then inherit. Also has anyone (@alexanderbates?) tested this?

R/cmtkreg.R Outdated Show resolved Hide resolved
@jefferis jefferis merged commit 7f1599c into master Aug 18, 2020
@jefferis
Copy link
Collaborator

Thanks @SridharJagannathan! Sorry for delayed merge.

@jefferis jefferis deleted the feature/plotly_grids_labels branch August 18, 2020 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants